Soft treshhold for the max batch size in bytes #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Thanks for your contribution!
I notice that the Java client handle CommandConnected event and use maxMessageSize also. Perhaps we can have a follow-up to handle it also.
Moreover, we always check full after queue the new message so it's a threshold than a guard, while we may check size before actually push_back.
|
cc @FlorentinDUBOIS @BewareMyPower for peer reviewing. @AfonsoRibeiro I'll appreciate it if you can add a function test. |
FlorentinDUBOIS
approved these changes
Apr 13, 2023
BewareMyPower
approved these changes
Apr 13, 2023
|
Merging... Potential improvements mentioned above can be follow-ups. Thanks a lot for your contribution @AfonsoRibeiro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this threshold is reached before batch size the batch is considered full and sent.
A soft threshold means there is no performance penalty with this implementation
#268