feat: hang on non-existed topics #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amehochan:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
amehochan
force-pushed
the
feature/dynamic-topics
branch
from
5f2660e
to
e8d4303
Compare
nlu90
reviewed
Feb 2, 2023
src/main/scala/org/apache/spark/sql/pulsar/PulsarMetadataReader.scala
Outdated
Show resolved
Hide resolved
amehochan
force-pushed
the
feature/dynamic-topics
branch
from
e8d4303
to
e6b5b61
Compare
I test the logic by using worksheet. But I don't know how to write the unit test. |
nlu90
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.