Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of 3d mode feature #1724

Closed
smichel17 opened this issue Feb 7, 2020 · 5 comments
Closed

Improve discoverability of 3d mode feature #1724

smichel17 opened this issue Feb 7, 2020 · 5 comments

Comments

@smichel17
Copy link
Member

I just discovered 3d mode. It's really cool, and learning about it has made me more interested in completing "number of stories" type quests. However, it was very hard to find. I only learned about it because I saw screenshots on some issues here on the repo, and even after that it took me around 15 minutes of combined reading (to see if anyone said how to do it) and trial and error to figure it out. For anyone else like me: tap the compass twice while your current location is locked on.

A big reason for this is that I don't lock on to my location very much. I do use my location, but I prefer to drag around the map to help orient myself and make sure I'm tagging the right building/road/etc. And I use the compass even less, because I prefer to keep the view oriented along the road I'm walking on. Ironically, 3d mode helps with both of those problems, if only I'd known about it.

Anyway, it's possible to unpin the location and scroll around once you've entered 3d mode, so it's unclear to me why you have to be location locked to enter it in the first place. I have tapped the compass multiple times (to no effect) when not locked on location, so I believe this would help with discovery.

@smichel17
Copy link
Member Author

Ah, I see. It's because compassMode is part of LocationAwareMapFragment and we use location lock to implicitly assume the type of map fragment 😈

@westnordost
Copy link
Member

You can also use the two-finger gesture (shove with two fingers) to tilt the map

@westnordost
Copy link
Member

So, I am closing this because it is already possible to enter 3D mode by tilting the map, no compass or location required.

@smichel17
Copy link
Member Author

smichel17 commented Feb 7, 2020

Technically yes, but this was more about the discoverability of the feature than the specific functionality.

@smichel17 smichel17 changed the title Allow entering 3d mode without first locking on current location Improve discoverability of 3d mode feature Feb 7, 2020
@smichel17
Copy link
Member Author

I was looking into this this morning, but ran out of time; I'll get back to it in the evening.

smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 7, 2020
For streetcomplete#1724

This implementation does not currently work because even when the tilt
has been set to 0f, it usually reports being very slightly tilted
(eg, tilt=5.317779E-7) and thus, isFlat is almost always false.
smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 8, 2020
smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 8, 2020
For streetcomplete#1724

Also use a kotlin scoping function to reduce verbosity
smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 8, 2020
smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 8, 2020
smichel17 added a commit to smichel17/StreetComplete that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants