Add Location.toLatLon util function #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't build, but makes sure git can track the file history; if we convert the file to kotlin all at once, it will think we deleted the old file and added a new one.
Done with the automatic converter, and then reformatted to match the previous style as closely as possible.
Instead of nesting inside an object Can't say I'm a huge fan of how many imports this generates, but I guess it is what it is.
smichel17
commented
Sep 9, 2021
app/src/main/java/de/westnordost/streetcomplete/quests/SplitWayFragment.kt
Show resolved
Hide resolved
westnordost
approved these changes
Sep 9, 2021
app/src/main/java/de/westnordost/streetcomplete/location/LocationUtil.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/SplitWayFragment.kt
Show resolved
Hide resolved
smichel17
commented
Sep 9, 2021
app/src/main/java/de/westnordost/streetcomplete/location/LocationUtil.kt
Outdated
Show resolved
Hide resolved
smichel17
commented
Sep 9, 2021
app/src/main/java/de/westnordost/streetcomplete/location/LocationUtil.kt
Outdated
Show resolved
Hide resolved
westnordost
approved these changes
Sep 9, 2021
|
thanks! |
|
Inching closer to 100% kotlin :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3166 (comment)
As I usually try for, going through this commit-by-commit may give you the most useful diffs, especially since the first 3 here are boilerplate.