Also check ways when tag is not always a node #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoniecz
requested changes
Apr 6, 2023
app/src/main/java/de/westnordost/streetcomplete/quests/barrier_type/AddBarrierType.kt
Outdated
Show resolved
Hide resolved
bus stops, water wells, and recycling containers occupy significant amounts of space. A quick look at the wiki suggests that indeed, more than 1% of them are tagged as ways/areas, and not as nodes: https://wiki.openstreetmap.org/wiki/Tag:public_transport=platform https://wiki.openstreetmap.org/wiki/Tag:man_made=water_well https://wiki.openstreetmap.org/wiki/Tag:recycling:glass=yes Therefore, StreetComplete should also check ways, and not only nodes.
BenWiederhake
force-pushed
the
dev-also-check-ways
branch
from
96dc396
to
ab5a910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by discussion in #4929, debug apk see https://github.com/BenWiederhake/StreetComplete/actions/runs/4623509091.
Barriers, bus stops, water wells, and recycling containers occupy significant amounts of space. A quick look at the wiki suggests that indeed, more than 1% of them are tagged as ways/areas, and not as nodes:
https://wiki.openstreetmap.org/wiki/Tag:barrier=yes
https://wiki.openstreetmap.org/wiki/Tag:public_transport=platform
https://wiki.openstreetmap.org/wiki/Tag:man_made=water_well
https://wiki.openstreetmap.org/wiki/Tag:recycling:glass=yes
Therefore, StreetComplete should also check ways, and not only nodes.
This means some "new" quests markers should pop up that have been skipped before, example:
Before this PR:
After this PR: