Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider banning whosonfirst.mapzen.com labels #14

Closed
matkoniecz opened this issue Oct 28, 2017 · 2 comments · Fixed by #26 or #71
Closed

consider banning whosonfirst.mapzen.com labels #14

matkoniecz opened this issue Oct 28, 2017 · 2 comments · Fixed by #26 or #71
Labels
enhancement

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Oct 28, 2017 •
edited

Mapzen data includes nonOSM data.

I am unsure whatever I am unlucky or overall data quality is low but whosonfirst.mapzen.com dataset at least in my region is full of malformed, duplicated and invalid labels (reported as tilezen/vector-datasource#1410 whosonfirst-data/whosonfirst-data#1008 whosonfirst-data/whosonfirst-data#1022 tilezen/vector-datasource#1418 ).

In addition this project seems to be quite slow to update, even with provided PRs - see https://github.com/whosonfirst-data/whosonfirst-data/pulls?page=2&q=is%3Apr+is%3Aopen

Malformed labels from external source are likely to be confusing for OSM editors - so maybe it would be a good idea to exclude them?
@ENT8R
Copy link
Collaborator

ENT8R commented Oct 28, 2017 •
edited

Yes, that's a good idea

@matkoniecz matkoniecz mentioned this issue Oct 29, 2017
Merged
@ENT8R ENT8R closed this as completed in #26 Oct 29, 2017
@ENT8R ENT8R mentioned this issue Aug 20, 2019
Closed
@westnordost westnordost reopened this Aug 20, 2019
@matkoniecz
Copy link
Member Author

It seems that filtering should be readded in https://github.com/ENT8R/streetcomplete-mapstyle/blob/master/layers/labels.yaml#L20

@matkoniecz matkoniecz mentioned this issue Aug 21, 2019
Merged
@ENT8R ENT8R closed this as completed in #71 Aug 21, 2019
ENT8R pushed a commit that referenced this issue Aug 21, 2019
@matkoniecz @ENT8R
Ban whosonfirst labels
613ce55 
low quality nonOSM source - duplicate, malformed, invalid labels unfixable in OSM would be confusing for OSM editors

see tilezen/vector-datasource#1410 whosonfirst-data/whosonfirst-data#1008 whosonfirst-data/whosonfirst-data#1022 tilezen/vector-datasource#1418

fixes #14 (again), repeats #26 and fixes streetcomplete/StreetComplete#1527
@ENT8R ENT8R mentioned this issue Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ban whosonfirst.mapzen.com labels
ban whosonfirst.mapzen.com labels
3 participants
@matkoniecz @westnordost @ENT8R