Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid label (stale or from an external source) #1410

Closed
matkoniecz opened this issue Oct 21, 2017 · 7 comments
Closed

invalid label (stale or from an external source) #1410

matkoniecz opened this issue Oct 21, 2017 · 7 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 21, 2017

  • What did you see?

label "Nowy Miasto" that appears to not be present in current OSM data

  • What did you expect to see?

nothing

  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.
  • Screenshot? Props for animated gifs.

selection_002

There are two problems with it - "Nowe Miasto" (described at https://pl.wikipedia.org/wiki/Nowe_Miasto_w_Krakowie ) is name for (partially/mostly/almost completely failed) urban project, I am not aware of anybody using this name as an orientation point/area of city (though I may be wrong - but given that it is missing from OSM despite good coverage of names at least indicates that I am not an outlier).

And certainly "Nowy Miasto" is ungrammatical, if anything it should be "Nowe Miasto".

In general, place names in Poland are rather well mapped and language is tricky so I am unsure about use of third-party data.

@matkoniecz matkoniecz changed the title invalid label (stale or from external source) invalid label (stale or from an external source) Oct 21, 2017
@zerebubuth
Copy link
Member

Thanks for pointing that out!

You're right; that label doesn't come from OSM. We take neighbourhood (and macrohood, microhood) labels from Who's On First, and they should be given a property source: whosonfirst.mapzen.com to recognise this in the output GeoJSON, TopoJSON or MVT.

I've submitted an issue about this datum on the main tracker. So hopefully will be fixed soon!

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 23, 2017

I missed source field, thanks for pointing this out!

I added

, not: {source: [whosonfirst.mapzen.com]}

to nix this value and future wrong values. I also fixed duplicates that I wanted to investigate for some time.

@nvkelso
Copy link
Member

nvkelso commented Oct 23, 2017

@matkoniecz Can you tell us more about the duplicates, please? We have bandwidth to fix them if you provide some direction.

Hiding all source: [whosonfirst.mapzen.com] will hide most neighbourhood labels on the map – unless the ones in OSM are tagged something other than neighbourhood.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 28, 2017

whosonfirst-data/whosonfirst-data#1022 - but I am unsure of

We have bandwidth to fix them if you provide some direction.

given what I see at https://github.com/whosonfirst-data/whosonfirst-data/pulls?page=2&q=is%3Apr+is%3Aopen

I will report more after issue that I just created is fixed and already produced PRs are processed.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 28, 2017

Hiding all source: [whosonfirst.mapzen.com] will hide most neighbourhood labels on the map – unless the ones in OSM are tagged something other than neighbourhood.

So OSM labels for neighbourhoods are discarded to make space for data from whosonfirst? At least in Kraków in my experience whosonfirst labels are quite low quality and using OSM data would be better.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 28, 2017

And clear duplicate reported at #1418

@nvkelso
Copy link
Member

nvkelso commented Sep 25, 2018

@matkoniecz FYI Who's On First PRs are back near "Inbox 0" levels.

@nvkelso nvkelso closed this as completed Sep 25, 2018
ENT8R pushed a commit to streetcomplete/streetcomplete-mapstyle that referenced this issue Aug 21, 2019
low quality nonOSM source - duplicate, malformed, invalid labels unfixable in OSM would be confusing for OSM editors

see tilezen/vector-datasource#1410 whosonfirst-data/whosonfirst-data#1008 whosonfirst-data/whosonfirst-data#1022 tilezen/vector-datasource#1418

fixes #14 (again), repeats #26 and fixes streetcomplete/StreetComplete#1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants