Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional OSM-only places layer #1418

Open
matkoniecz opened this issue Oct 28, 2017 · 4 comments
Open

Optional OSM-only places layer #1418

matkoniecz opened this issue Oct 28, 2017 · 4 comments

Comments

@matkoniecz
Copy link
Contributor

  • What did you see? two labels for Kleparz
  • What did you expect to see? one label
  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.

https://mapzen.com/tangram/play/?#17.50000/50.07097/19.94142

  • Screenshot? Props for animated gifs.

selection_004

with https://github.com/ENT8R/streetcomplete-mapstyle/blob/283c61b29f27cc6f018d84ba364662be6d9ea12d/style.yaml style (reporting here as whosonfirst.mapzen.com may be correct in this case)

@zerebubuth
Copy link
Member

Looks like the label on the left comes from WOF as a neighbourhood, and the label on the right comes from OSM as a locality. We removed OSM neighbourhoods in #359 and followed up with boroughs, suburbs and quarters in #744, because of duplicates similar to these. However, we still include localities and various other place types from OSM.

Might it be worth including both sets of data, perhaps in separate layers, to allow style designers to choose which data set works best? I haven't checked, but my assumption is that these "high zoom" place types don't contribute a huge amount to tile size.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 30, 2017

Might it be worth including both sets of data

For what is it worth I would happily use that. In my case I prefer OSM data as at least in my region it is of higher quality and as an OSM mapper even wrong OSM data is also welcomed - I just edit and fix it. The same applies for other internal OSM styles, like ongoing style for StreetComplete.

@nvkelso nvkelso changed the title duplicated label Optional OSM-only places layer Oct 30, 2017
@nvkelso
Copy link
Member

nvkelso commented Oct 30, 2017

Putting on my project manager hat here: The default places layer shouldn't have duplicate features in it, but for practical reasons it does today and will for a little bit longer. As @zerebubuth points out the duplicate here is because we're sourcing categorically (by kind) between OSM and Who's On First and the categorization is not the same. I'm open to including an optional OSM-only places layer, but that's unlikely to be the default places because of other Mapzen projects and priorities. Retitling this issue to capture that idea (as otherwise it's a dup of your earlier issue).

@nvkelso
Copy link
Member

nvkelso commented Feb 13, 2019

Related to #383, which deals with mixed Natural Earth and OpenStreetMap data for places layer locality features.

ENT8R pushed a commit to streetcomplete/streetcomplete-mapstyle that referenced this issue Aug 21, 2019
low quality nonOSM source - duplicate, malformed, invalid labels unfixable in OSM would be confusing for OSM editors

see tilezen/vector-datasource#1410 whosonfirst-data/whosonfirst-data#1008 whosonfirst-data/whosonfirst-data#1022 tilezen/vector-datasource#1418

fixes #14 (again), repeats #26 and fixes streetcomplete/StreetComplete#1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants