Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve imports from ESLint plugin #5790

Merged
merged 9 commits into from
Jun 24, 2024
Merged

fix: resolve imports from ESLint plugin #5790

merged 9 commits into from
Jun 24, 2024

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Jun 20, 2024

fixes #5789

@github-actions github-actions bot added the fix label Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Performance Report

Repository Elapsed Min/Avg/Max SD SD Graph
AdaDoom3/AdaDoom3 11.96 11.9 / 12.3 / 13.8 0.33 ┣━━●━━╋━━┻━━┫
alexiosc/megistos 30.76 29.5 / 31.1 / 33.0 0.78 ┣━━┻━●╋━━┻━━┫
apollographql/apollo-server 6.83 6.4 / 6.7 / 7.0 0.17 ┣━┻━━╋●━┻━┫
aspnetboilerplate/aspnetboilerplate 25.15 23.3 / 24.7 / 26.4 0.74 ┣━━┻━━╋━●┻━━┫
aws-amplify/docs 35.62 35.3 / 37.8 / 61.0 4.14 ┣━━━┻●━╋━━┻━━━┫
Azure/azure-rest-api-specs 32.19 30.1 / 32.1 / 34.3 1.08 ┣━━┻━━●━━┻━━┫
bitjson/typescript-starter 0.87 0.8 / 0.9 / 1.1 0.06 ┣━━┻━●━┻━━┫
caddyserver/caddy 11.60 11.2 / 11.8 / 12.3 0.29 ┣━━┻●━╋━━┻━━┫
canada-ca/open-source-logiciel-libre 1.01 0.9 / 1.0 / 1.1 0.03 ┣━━┻━╋●┻━━┫
chef/chef 20.47 19.8 / 20.6 / 21.9 0.58 ┣━━┻━●╋━━┻━━┫
django/django 53.63 50.2 / 52.8 / 55.5 1.10 ┣━━━┻━━╋━●┻━━━┫
eslint/eslint 31.54 29.7 / 31.7 / 33.7 0.85 ┣━━┻━●╋━━┻━━┫
exonum/exonum 11.94 11.3 / 11.7 / 12.3 0.26 ┣━━┻━━╋━●┻━━┫
gitbucket/gitbucket 6.93 6.7 / 7.0 / 7.4 0.21 ┣━┻━●╋━━┻━┫
googleapis/google-cloud-cpp 385.29 378.1 / 394.3 / 419.4 10.36 ┣━━━●━━━╋━━━┻━━━┫
graphql/express-graphql 0.90 0.9 / 0.9 / 1.0 0.03 ┣━━●━╋━┻━━┫
graphql/graphql-js 6.07 5.7 / 6.0 / 6.6 0.17 ┣━┻━━╋●━┻━┫
graphql/graphql-relay-js 0.91 0.9 / 0.9 / 1.1 0.04 ┣━━●━╋━┻━━┫
graphql/graphql-spec 1.88 1.8 / 1.9 / 2.0 0.05 ┣━━┻●╋━┻━━┫
iluwatar/java-design-patterns 31.87 31.1 / 33.3 / 36.2 1.11 ┣━●┻━━╋━━┻━━┫
ktaranov/sqlserver-kit 23.92 22.1 / 23.3 / 25.3 0.63 ┣━━┻━━╋━━●━━┫
liriliri/licia 8.30 7.5 / 8.0 / 8.7 0.30 ┣━━┻━━╋━━●━━┫
MartinThoma/LaTeX-examples 14.24 13.3 / 14.1 / 15.2 0.42 ┣━━┻━━╋●━┻━━┫
mdx-js/mdx 3.73 3.7 / 3.8 / 4.1 0.11 ┣━●━━╋━━┻━┫
microsoft/TypeScript-Website 18.37 17.4 / 18.6 / 20.6 0.91 ┣━━┻━●╋━━┻━━┫
MicrosoftDocs/PowerShell-Docs 87.96 85.7 / 89.3 / 94.4 1.95 ┣━━━┻●━╋━━┻━━━┫
neovim/nvim-lspconfig 8.96 8.6 / 9.1 / 9.7 0.22 ┣━━┻●━╋━━┻━━┫
pagekit/pagekit 7.47 7.3 / 7.7 / 8.3 0.22 ┣━━●━━╋━━┻━━┫
php/php-src 120.20 110.9 / 116.1 / 139.3 5.06 ┣━━┻━━━╋━━●┻━━┫
plasticrake/tplink-smarthome-api 1.50 1.5 / 1.5 / 1.7 0.05 ┣━━●━╋━┻━━┫
prettier/prettier 13.49 12.8 / 13.4 / 14.2 0.33 ┣━━┻━━╋●━┻━━┫
pycontribs/jira 2.79 2.5 / 2.7 / 3.1 0.10 ┣━┻━━╋━━●━┫
RustPython/RustPython 14.59 13.9 / 14.5 / 15.9 0.43 ┣━━┻━━╋●━┻━━┫
shoelace-style/shoelace 7.77 7.1 / 7.4 / 8.5 0.29 ┣━━┻━━╋━━●━━┫
SoftwareBrothers/admin-bro 4.60 4.5 / 4.7 / 5.0 0.14 ┣━┻━●╋━━┻━┫
sveltejs/svelte 37.42 36.6 / 37.9 / 39.5 0.81 ┣━━┻●━╋━━┻━━┫
TheAlgorithms/Python 17.08 16.4 / 17.0 / 18.1 0.42 ┣━━┻━━●━━┻━━┫
twbs/bootstrap 3.78 3.6 / 3.7 / 4.0 0.11 ┣━┻━━╋●━┻━┫
typescript-cheatsheets/react 2.15 2.0 / 2.1 / 2.3 0.07 ┣━━┻━╋●┻━━┫
typescript-eslint/typescript-eslint 6.36 6.4 / 6.7 / 7.5 0.25 ┣━●┻━━╋━━┻━━┫
w3c/aria-practices 9.93 9.2 / 9.7 / 10.5 0.31 ┣━━┻━━╋━●┻━━┫
w3c/specberus 3.14 2.8 / 3.0 / 3.3 0.09 ┣━┻━━╋━━┻━●
webdeveric/webpack-assets-manifest 0.82 0.8 / 0.8 / 1.0 0.04 ┣━━┻●╋━┻━━┫
webpack/webpack 12.33 11.8 / 12.3 / 13.0 0.31 ┣━━┻━━╋●━┻━━┫
wireapp/wire-desktop 1.33 1.3 / 1.4 / 1.6 0.07 ┣━━┻●╋━┻━━┫
wireapp/wire-webapp 21.53 19.5 / 21.5 / 22.7 0.62 ┣━━┻━━●━━┻━━┫
Repository Elapsed Rel Trend Count
AdaDoom3/AdaDoom3 11.96 -2.78% ▂▄▄▃▂▃▄▂▅▆▄▄▅▄▃▄▃▃█▂ 33
alexiosc/megistos 30.76 -0.98% ▃▅▃▄▄ ▂▃▆▅▅▁▃▃▅▄▅▂▁▃ 33
apollographql/apollo-server 6.83 1.28% ▅▃▃▄▆▃▃▆▅▄▃▃▆▅▃▆▃▂▄▅ 33
aspnetboilerplate/aspnetboilerplate 25.15 1.70% ▆▃▃▆▃▃▄▃▄▆▃▄▇▇▃▄▃▄▃▅ 34
aws-amplify/docs 35.62 -5.78% ▃▃▃▃▃▃▃▃▃▄▄▄█▃▃▄▃▄▃▃ 34
Azure/azure-rest-api-specs 32.19 0.40% ▃▃▆▁▅▃▅▆▅▄▄▃▂▅▃▃▄▆▁▄ 34
bitjson/typescript-starter 0.87 -0.74% ▄▂▇▃▃▃▄▃▄▂▃▃▃▃▇▃▃▃▃▄ 33
caddyserver/caddy 11.60 -1.49% ▃▁▂▃▆▄▄▃▄▄▆▃▅▅▄▂▄▇▄▃ 34
canada-ca/open-source-logiciel-libre 1.01 1.57% ▃▃▄▂▅▂▃ ▄▃▅▄▄▅▃▂▂▃▄▄ 33
chef/chef 20.47 -0.74% ▂▂▁▅▃▃▄▇▃▃▄▇▄▄▆▂▄▂▇▃ 34
django/django 53.63 1.48% ▃▄▂▄▄▃▇▆▃▄▆▃▂▅▅▅▄▄▃▅ 34
eslint/eslint 31.54 -0.46% ▅▃▅▄▄▄▂▇▄▄▇▂▃▃▄▃▄▃▃▃ 34
exonum/exonum 11.94 1.77% ▂▃▄▄▇▃▁▂▄▃▂▆▃▄▆▂▃▂▇▅ 33
gitbucket/gitbucket 6.93 -0.64% ▅▃▅▄▂▂▇▃▅▄▄▂▄▇▃▃▆▁▃▃ 34
googleapis/google-cloud-cpp 385.29 -2.29% ▁▅▆▃▂▄▃▄▅▅█▂▄█▄▄▃▂▄▂ 34
graphql/express-graphql 0.90 -2.48% ▂▄▂▂▄▂▃▂▄▆▄▄▃▄▆▄▅▄▂▃ 33
graphql/graphql-js 6.07 1.11% ▄█▄▅▄▄▂▂▂▃▃▃▄▄▂▃▅▃▇▄ 34
graphql/graphql-relay-js 0.91 -3.14% ▃▃▂▃▃▂▂▂▃▅█▄▃▅▃▂▄▃▃▃ 33
graphql/graphql-spec 1.88 -1.10% █▃▃▄▄▅▃▅▅▂▇▂▃▇▃▃▃▂▂▃ 34
iluwatar/java-design-patterns 31.87 -4.41% ▄▃▄▅▄▄▄▂▇▃▅▆▅▄▇▃▂▄▄▂ 34
ktaranov/sqlserver-kit 23.92 2.71% ▄▁▄▁▄▄▅▄▄▇▃▃▄▄▃▁▄▃▅▅ 33
liriliri/licia 8.30 3.95% ▃▄▄▄▆▇▄▃▆▇▅▂▄▂▅▃▂▄▄▅ 34
MartinThoma/LaTeX-examples 14.24 1.24% ▃▃▄▂▄▆▄▆▅▃▅▅▆▄▃▃▃▆▃▄ 33
mdx-js/mdx 3.73 -3.07% ▅▂▄▅▄▅▃▄▅▂▃▆▂▆▂▆▆▃▃▂ 33
microsoft/TypeScript-Website 18.37 -1.22% ▃▂▂▃▃▃▂▃▃▂▂▂▃▃▅▂▃▂▃▃ 34
MicrosoftDocs/PowerShell-Docs 87.96 -1.49% ▂▃▃▄▃▁█▂▄▄▆▃▇▅▅▃▂▂▅▃ 34
neovim/nvim-lspconfig 8.96 -1.61% ▅▃▅▄▄▅▃▄▄▁▄▃▃▃▂▄▅▂▆▃ 34
pagekit/pagekit 7.47 -2.80% █▃▄▂▄▄▂▄▂▃▅▁▅▅▂▂▄▅▃▂ 33
php/php-src 120.20 3.55% ▃▃▃█▂▃▅▄▄▄▄▃▃▂▃▂▄▅▃▅ 34
plasticrake/tplink-smarthome-api 1.50 -2.82% ▃▂▅▅▄▃█▄▄▄▄▃▅▃▃▃▄▂▂▂ 33
prettier/prettier 13.49 0.72% ▆▅▇▁▅▃▄▅▃▅▄▅▆█▂▄▃▃▃▄ 34
pycontribs/jira 2.79 4.44% ▄▄▄▄▄▂▃▃▄▃█▂▃▅▅▅▂▅▃▆ 33
RustPython/RustPython 14.59 0.57% ▃▅▄▃▂▂▅▅▃▃▃▆▂▆▄▃▂▅▂▄ 34
shoelace-style/shoelace 7.77 4.46% ▇▄▃▄▃▂▃▂▂▃▃▂▃▃▅▄▃▄▃▆ 34
SoftwareBrothers/admin-bro 4.60 -1.58% ▃▃▄▃▅▃▃▇▃▅▃▆▂▁▇▄▃▃▄▃ 33
sveltejs/svelte 37.42 -1.23% ▃▅▆▂▃▅▄▃▇▄▃▄▂▅▃▃▂▄▂▃ 34
TheAlgorithms/Python 17.08 0.30% ▄▅▂▃▂▅▄▄▅█▃▃▆▇▃▅▄▂▃▄ 34
twbs/bootstrap 3.78 1.55% ▅▄▄▃▆▂▁▇▄▅▄▅▂▃▅▂▂▃▄▅ 34
typescript-cheatsheets/react 2.15 1.25% ▃▃▂▂▇▄▆▄▃▂▄▄▆█▆▄▃▃▂▄ 33
typescript-eslint/typescript-eslint 6.36 -5.17% ▅▄▄▄▄▄▃▂▃▂▃▃▂▄▃▄▆▄▃▂ 34
w3c/aria-practices 9.93 2.38% ▂▄▄▃▄▂▂▃▃▅▅▄▂▃▃▃▅▂▂▅ 33
w3c/specberus 3.14 5.87% █▄▂▄▂▂▄▄▂▃▆▃▃▇▃█▃▅▄▇ 34
webdeveric/webpack-assets-manifest 0.82 -2.90% ▃▃▄▃▄▃▃▃▃▃▄▄▃▄▂▅▄▂▃▃ 33
webpack/webpack 12.33 0.50% ▄▂▂▂▃▂▆▂▃▄▆▄▅▇▂▅▄▁▃▄ 34
wireapp/wire-desktop 1.33 -1.46% ▆▃▃▃▃▃▄▃▄▃▄▃▄▃▃▃▅▃▂▃ 34
wireapp/wire-webapp 21.53 -0.02% ▂▃▃▄▆▃▂▃▄▄▅▄▆▇▄▃▃▃▂▄ 34

Note:

  • Elapsed time is in seconds. The trend graph shows the last 10 runs.
    The SD graph shows the current run relative to the average and standard deviation.
  • Rel is the relative change from the average.

Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a draft, but here are my feedbacks

packages/cspell-eslint-plugin/package.json Outdated Show resolved Hide resolved
@Jason3S Jason3S force-pushed the dev-eslint-import branch 2 times, most recently from 640bf63 to 8930a42 Compare June 21, 2024 09:39
@ccoVeille
Copy link

if you are not in a hurry to merge that I would be happy to review your changes

@Jason3S
Copy link
Collaborator Author

Jason3S commented Jun 21, 2024

if you are not in a hurry to merge that I would be happy to review your changes

I'm not in a hurry. Your feedback is welcome.

I have one more change I'm planning on making:

  • Be able to pass the configLocation used to resolve the import as an option.

@ccoVeille
Copy link

LGTM 👍

There is no more decency to a roblox lib

@Jason3S
Copy link
Collaborator Author

Jason3S commented Jun 23, 2024

LGTM 👍

There is no more decency to a roblox lib

Thank you for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESLint] How to export custom dictionary with config
2 participants