-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve imports from ESLint plugin #5790
Conversation
Performance Report
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a draft, but here are my feedbacks
packages/cspell-eslint-plugin/src/plugin/cspell-eslint-plugin.cts
Outdated
Show resolved
Hide resolved
640bf63
to
8930a42
Compare
if you are not in a hurry to merge that I would be happy to review your changes |
I'm not in a hurry. Your feedback is welcome. I have one more change I'm planning on making:
|
c2c7db9
to
4afad05
Compare
LGTM 👍 There is no more decency to a roblox lib |
Do not resolve if there are no imports.
4afad05
to
9d50105
Compare
Thank you for taking a look. |
fixes #5789