Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve paths beginning with tilde as $HOME #83

Merged
merged 1 commit into from
May 13, 2019

Conversation

tribut
Copy link
Contributor

@tribut tribut commented Mar 11, 2019

This allows configuration files to be used across multiple machines where absolute paths may differ.

Please let me know if you have any objections to the test. It feels a bit weird to re-use the default settings that way, but it is less verbose than creating a new settings object just for this test.

@coveralls
Copy link

coveralls commented Mar 11, 2019

Coverage Status

Coverage increased (+0.003%) to 94.653% when pulling e6413cb on tribut:resolve-tilde-home into ecf9ee8 on streetsidesoftware:master.

@Jason3S
Copy link
Collaborator

Jason3S commented May 13, 2019

Great suggestion. Sorry about not pulling this in.

@Jason3S
Copy link
Collaborator

Jason3S commented May 13, 2019

I'm happy to pull this in. The files you changed were moved to packages/cspell/src.

@tribut
Copy link
Contributor Author

tribut commented May 13, 2019

Rebased.

This allows configuration files to be used across multiple machines
where absolute paths may differ.
@Jason3S
Copy link
Collaborator

Jason3S commented May 13, 2019

Thank you.

@Jason3S Jason3S merged commit eeb8d32 into streetsidesoftware:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants