Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Go 1.18.1 as a build/supported version #1182

Merged
merged 5 commits into from Jun 14, 2022
Merged

Conversation

boyan-soubachov
Copy link
Collaborator

@boyan-soubachov boyan-soubachov commented May 4, 2022

Summary

Added Go 1.18.1, removed Go 1.15.13 from the build versions. This brings us up-to-date with the latest supported Go versions.

Changes

Add Go 1.18.1
Removed Go 1.15.13 as a build version as it's no longer supported

@boyan-soubachov boyan-soubachov merged commit 3c33e07 into master Jun 14, 2022
6 checks passed
@boyan-soubachov boyan-soubachov deleted the bvs/add_go_1.18 branch Jun 14, 2022
wenlock added a commit to wenlock/testify that referenced this issue Jun 23, 2022
This reverts a change that was made in stretchr#1182
The PR makes m.mutex a pointer which now needs to be checked but it's not checked for nil everywhere.

This should also help with these issues:
- stretchr#1208
- stretchr#1210
boyan-soubachov pushed a commit that referenced this issue Jun 24, 2022
* fixing panic in calls to assertion with nil m.mutex

This reverts a change that was made in #1182
The PR makes m.mutex a pointer which now needs to be checked but it's not checked for nil everywhere.

This should also help with these issues:
- #1208
- #1210

* Revert throwing out the lock because other concurrent calls can already have it locked

* fix go vet copy lock by using pointer

* fix obj assignment for passing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant