-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PanicAssertionFunc #1337
Merged
Merged
Add PanicAssertionFunc #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dolmen
requested changes
Jul 6, 2023
fahimbagar
force-pushed
the
PanicAssertionFunc
branch
from
July 6, 2023 09:38
dc1948b
to
8b93e11
Compare
dolmen
requested changes
Mar 4, 2024
assert/assertions_test.go
Outdated
|
||
tests := []struct { | ||
name string | ||
panicFn func() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type should be PanicTestFunc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and updated the type
fahimbagar
force-pushed
the
PanicAssertionFunc
branch
from
March 5, 2024 05:12
8b93e11
to
2ab33d6
Compare
dolmen
approved these changes
Mar 5, 2024
Thanks @dolmen |
Thanks @fahimbagar ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
PanicAssertionFunc
to ease writing table-driven tests for panic assertion.Changes
PanicAssertionFunc
for table driven.Motivation
https://github.com/fahimbagar/testify/blob/cb954e70769531b0462ae2f713c12c74e64ad69c/assert/assertions_test.go#L2410-L2427
Related issues
Closes #730