assert.EqualExportedValues: accepts everything #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
changed the title
dolmen
added
assert.EqualValues
HaraldNordgren
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Looks good! I wrote a big part of that function. For me, it was never intended to not work for this use case.
Let's merge this @dolmen?
brackendawson
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
LGTM
I think the existing doc string for EqualExportedValues is approprioate. In fact I think this code is a more faithful implementation of the documented promise.
It works, I've tried to break it. It is well tested.
Going to allow a little time for other maintainers to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove type validation in EqualExportedValues
See #1584.