Correct the EventuallyWithT and EventuallyWithTf example #1588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The example used for
EventuallyWithT
documentation doesn't actually pass.Changes
Updated the example to be correct by swapping the times used for
waitFor
andtick
Motivation
I was looking at the docs and, based on the example, mistakenly set
waitFor
to be a shorter time thantick
, which meanscondition
never gets called. Hopefully this helps other people avoid the same mistake.