Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required go version in README.md #1602

Conversation

lord63
Copy link

@lord63 lord63 commented May 27, 2024

Summary

Update the minimum required go version in readme. Since the go.mod and the ci says the minimum version should be 1.17.

Changes

No other changes, just update the readme.

Motivation

Update and clarify the minimum required go version, so 1.17 and 1.18 go version users will have a try.

Related issues

None

@brackendawson
Copy link
Collaborator

The supported version is the standard we hold ourselves to providing support for. We deliberately leave the go directive set to a correct value though, which lags behind, in order for it to be correct (the source code itself really does "target" that release), and going forward past 1.20 to not flatly break the people we don't support.

@dolmen
Copy link
Collaborator

dolmen commented Jun 6, 2024

While we still aim to support Go from 1.17, this is a best effort and we don't want our users to rely to much on this as time passes.

So I'm fine with the README mentioning a more recent version than what is in go.mod. Go 1.19 is already quite old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants