Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollable columns #200

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Add scrollable columns #200

merged 2 commits into from
Jul 22, 2017

Conversation

ddipanfilo
Copy link
Contributor

scrolling_fun_with_charles

@sourcelevel-bot
Copy link

Hello, @ddipanfilo! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.784% when pulling 92a79dd on make_idea_lists_scrollable into f5ede30 on master.

…looking for the list

  - the list visibility is affected by the css updates of the scrollable columns feature
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.784% when pulling 876676b on make_idea_lists_scrollable into ead21fa on master.

@vanderhoop
Copy link
Contributor

hey @ddipanfilo, @crq, and @samdec11. the css changed the way PhantomJS saw the visibility of the lists, so i updated the end-to-end tests to look for the inclusion (or lack thereof) of the <li>s in question, and the build passes consistently. mergin!

@vanderhoop vanderhoop merged commit a68ba92 into master Jul 22, 2017
@vanderhoop vanderhoop deleted the make_idea_lists_scrollable branch July 22, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants