Fix modal warning in console and tests #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderhoop
reviewed
Feb 15, 2018
web/static/js/components/alert.jsx
Outdated
| @@ -10,6 +10,11 @@ Modal.defaultStyles.content.zIndex = 2 | |||
| Modal.defaultStyles.overlay.zIndex = 2 | |||
|
|
|||
| export class Alert extends Component { | |||
|
|
|||
| componentWillMount() { | |||
There was a problem hiding this comment.
does this need to be set in componentWillMount? could we set it after the zIndex assignments on line 9 and 10?
There was a problem hiding this comment.
also, i think the app element might be selected via .react-root, rather than body, as that's the div that our react app mounts to
There was a problem hiding this comment.
Yes, we can set it after the zIndex and it works.
So I tried setting it to .react-root but the alert-tests fail, and I'm not entirely sure why. Example of one failure:
Alert component
"before each" hook for "renders the headerText in a header text component":
Error: react-modal: No elements were found for selector .remote-root.
|
woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes introduced:
The following warning is shown in both the console and the e2e test output:
react-modal: App element is not defined. Please useModal.setAppElement(el)or setappElement={el}. This is needed so screen readers don't see main content when modal is opened. It is not recommendedThis fix will set the element before the render with
componentWillMont()A few references:
reactjs/react-modal#133
https://stackoverflow.com/questions/48269381/warning-react-modal-app-element-is-not-defined-please-use-modal-setappeleme
reactjs/react-modal#576