fix: PublishSingleFile Launch Crash #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix for Windows executable launch crash when game is published with PublishSingleFile set to true
|
Might be able to also close #1947 with this fix. |
That's a good idea, inline with that the docs should also be updated at some point to include PublishSingleFile instructions. https://doc.stride3d.net/latest/en/manual/files-and-folders/distribute-a-game.html |
Kryptos-FR
reviewed
Apr 11, 2024
| @@ -186,6 +186,8 @@ private static string GetApplicationBinaryDirectory() | |||
| { | |||
| #if STRIDE_PLATFORM_ANDROID | |||
| return GetApplicationExecutableDirectory(); | |||
| #elif STRIDE_PLATFORM_DESKTOP | |||
| return Path.GetDirectoryName(AppContext.BaseDirectory); | |||
There was a problem hiding this comment.
Is this a correct path if not published as single file?
There was a problem hiding this comment.
I believe so. My tests included both single file and non single file published builds, all launched without issue.
Eideren
changed the title
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Stride applications built for Windows will crash when PublishSingleFile is set to true.
Description
When a Stride application is launched,
Assembly.Locationis used to find the executable directory and create cache folders. This returns a null value when PublishSingleFile is true. It is instead recommended to useAppContext.BaseDirectoryto check for the executable directory.Additional Info: https://learn.microsoft.com/en-us/dotnet/core/deploying/single-file/warnings/il3000
Related Issue
#2204
Types of changes
Checklist