Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix precision fallback code #54

Closed
Strilanc opened this issue Apr 5, 2016 · 1 comment
Closed

Test and fix precision fallback code #54

Strilanc opened this issue Apr 5, 2016 · 1 comment

Comments

@Strilanc
Copy link
Owner

Strilanc commented Apr 5, 2016

Apparently gl.getShaderPrecisionFormat returns null or undefined in some cases, so the current code just crashes when high precision isn't supported. The webgl code needs to be tested on lower capability machines. Ideally automatically.

Look for services that can run CI tests including webgl on a variety of machines.
@Strilanc
Copy link
Owner Author

Strilanc commented May 4, 2016

The person who was reporting this bug appears to be able to use Quirk now, so this may have been fixed by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Strilanc