Add available ratio limit type #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
reviewed
Mar 1, 2023
tombentley
approved these changes
Mar 1, 2023
src/main/java/io/strimzi/kafka/quotas/PerVolumeThrottleFactorPolicy.java
Show resolved
Hide resolved
src/main/java/io/strimzi/kafka/quotas/PerVolumeThrottleFactorPolicy.java
Show resolved
Hide resolved
src/main/java/io/strimzi/kafka/quotas/AvailableBytesThrottleFactorPolicy.java
Outdated
Show resolved
Hide resolved
Enables users to throttle the produce quota when the availableRatio (availableBytes/totalBytes) is less than or equal to a threshold. The new configuration property is: `client.quota.callback.static.storage.per.volume.limit.min.available.ratio` Which accepts a double between 0 and 1 inclusive Why: It may be convenient to be able to throttle message production when any volume's usage ratio drops below a threshold. This means you could have a single configuration for heterogeneous disks saying cease all message production if any volume's available ratio is below 0.01 See Also: * https://github.com/strimzi/proposals/blob/main/047-cluster-wide-volume-usage-quota-management.md * [Add min available bytes storage policy](strimzi#33) Signed-off-by: Robert Young <robeyoun@redhat.com> refactor: extract a base class for policies applied to any volume Signed-off-by: Robert Young <robeyoun@redhat.com>
robobario
force-pushed
the
add-available-ratio-limit-type
branch
from
1768bbd
to
c1ee697
Compare
|
Sorry, things got a little messy with DCO since I merged master in and then committed without signoff, wasn't confident in rebasing the merge commit so I folded it all into the first commit. The only changes were addressing the review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to throttle the produce quota when the availableRatio (availableBytes/totalBytes) is less than or equal to a threshold.
The new configuration property is:
client.quota.callback.static.storage.per.volume.limit.min.available.ratioWhich accepts a double between 0 and 1 inclusive
Why:
It may be convenient to be able to throttle message production when any volume's usage ratio drops below a threshold. This means you could have a single configuration for heterogeneous disks saying cease all message production if any volume's available ratio is below 0.01
See Also: