-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the building of docker image #574
Conversation
This should also fix the automated container build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @vitkabele! A couple of minor comments, but looks pretty good!
Dockerfile
Outdated
@@ -7,7 +7,7 @@ EXPOSE 8080 | |||
|
|||
WORKDIR /app | |||
ADD Gemfile Gemfile.lock /app/ | |||
RUN bundle install --deployment | |||
RUN bundle config set --local deployment 'true' && bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the quotes around 'true'
here. All CLI arguments get passed through as strings to Ruby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could. This is what the bundler itself told me that is the preferred way :).
Dockerfile
Outdated
@@ -36,7 +36,7 @@ ADD docker/start.sh /app/ | |||
ADD . /app | |||
|
|||
RUN useradd -m stringer | |||
RUN chown -R stringer:stringer /app | |||
RUN chown -R stringer:stringer /app /etc/supervisord.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me more about why this was necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the supervisord is failing with error "Cannot read /etc/supervisord.conf"
Sadly all attempts to run the container ends with:
Any ideas? The problem is clearly with initial user creation, but I don't have time to solve it now. This is WIP until resolved. EDIT: Everything works after the user is created manually. And this problem also happens on the official image from hub.docker.com |
Should work now. Please check |
Fixes #523.
Building Docker image was failing due to the outdated ruby base image. Updated to ruby:latest.