Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit ES6 for greater compability #23

Merged
merged 1 commit into from
May 23, 2023
Merged

Emit ES6 for greater compability #23

merged 1 commit into from
May 23, 2023

Conversation

jojo-stripe
Copy link
Contributor

Previously we were emitting esnext code which was not compatible with older versions of react. Emitting less modern code so we have greater compability.

Also noticed a typo in our publish script

@@ -1,7 +1,7 @@
{
"compilerOptions": {
// Let Babel deal with transpiling new language features
"target": "esnext",
"target": "ES6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the ?? operator being transformed 👍

image

@jojo-stripe jojo-stripe merged commit 68a60fe into master May 23, 2023
@jojo-stripe jojo-stripe deleted the jojo/emit branch May 23, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants