-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MiMA and fix issues it noticed. #44
Conversation
We want compatibility with 0.3.0, so I updated the plugin, updated the version to be checked (was 0.2.4 which meant lots of bogus incompatibilities were reported) and then fixed the issues.
You can verify with |
Once this lands I want to do a release for Scala 2.13. |
Looks good but CI failed. After we merge this and when we next need to break we should remove that compatibility method since the name is brutal. |
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 84.57% 82.71% -1.87%
==========================================
Files 13 13
Lines 376 376
Branches 20 16 -4
==========================================
- Hits 318 311 -7
- Misses 58 65 +7
Continue to review full report at Codecov.
|
@johnynek A lot of these updates are to get MiMA and Travis working, but the rest are to get ready for trying to support Scala 2.13. We're going to have to decide what to do about |
Sure, I think that’s fine. Let’s do 0.4.0 and minimize hacks. |
|
||
lazy val commonJvmSettings = Seq( | ||
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest, "-oDF")) | ||
|
||
lazy val commonJsSettings = Seq( | ||
scalaJSStage in Global := FastOptStage, | ||
parallelExecution := false, | ||
requiresDOM := false, | ||
jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this line duplicated below?
@@ -833,7 +832,8 @@ class DataFlowTest extends FunSuite { | |||
if (incs <= 0) f | |||
else incrementChain(f.map(_ + 1), incs - 1) | |||
|
|||
val incCount = if (catalysts.Platform.isJvm) 10000 else 1000 | |||
//val incCount = if (catalysts.Platform.isJvm) 10000 else 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think testing this with 1000 destroys the test. This is about the stack, I think... but we can deal with it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, catalysts isn't published for 2.13 so I was gonna disable this then try to fix it.
def com$stripe$dagon$Dag$$copy$default$2(): com.stripe.dagon.FunctionK[N, Literal[N, ?]] = | ||
self.toLiteral | ||
|
||
def com$stripe$dagon$Dag$$copy$default$3(): scala.collection.immutable.Set[Id[_]] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet if you make these private[paiges]
it is still binary compatible but no one in scala can see them. What do you think about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We want compatibility with 0.3.0, so I updated the plugin, updated the version
to be checked (was 0.2.4 which meant lots of bogus incompatibilities were
reported) and then fixed the issues.