Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Dagon API a bit. #7

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Clean up Dagon API a bit. #7

merged 2 commits into from
Aug 29, 2017

Conversation

non
Copy link
Collaborator

@non non commented Aug 29, 2017

  • Introduce Cache analog to HCache
  • Rename ExpressionDag to Dag
  • Move DependantGraph to tests, rename to SimpleDag
  • A bit of other code clean up
  • Some extra docs

 * Introduce Cache analog to HCache
 * Rename ExpressionDag to Dag
 * Move DependantGraph to tests, rename to SimpleDag
 * A bit of other code clean up
 * Some extra docs
@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #7 into master will decrease coverage by 1.97%.
The diff coverage is 74.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #7      +/-   ##
=========================================
- Coverage   86.38%   84.4%   -1.98%     
=========================================
  Files          12      12              
  Lines         191     186       -5     
  Branches       14      13       -1     
=========================================
- Hits          165     157       -8     
- Misses         26      29       +3
Impacted Files Coverage Δ
.../src/main/scala/com/stripe/dagon/PartialRule.scala 100% <ø> (ø) ⬆️
core/src/main/scala/com/stripe/dagon/Id.scala 100% <ø> (ø) ⬆️
core/src/main/scala/com/stripe/dagon/Dag.scala 93.93% <100%> (ø)
core/src/main/scala/com/stripe/dagon/Memoize.scala 100% <100%> (ø) ⬆️
core/src/main/scala/com/stripe/dagon/HCache.scala 57.14% <25%> (-9.53%) ⬇️
core/src/main/scala/com/stripe/dagon/Cache.scala 57.14% <57.14%> (ø)
core/src/main/scala/com/stripe/dagon/Rule.scala 75% <71.42%> (ø) ⬆️
core/src/main/scala/com/stripe/dagon/HMap.scala 75% <75%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c2f2e...b6c967b. Read the comment docs.

@oscar-stripe oscar-stripe merged commit 38f21d7 into master Aug 29, 2017
@oscar-stripe oscar-stripe deleted the api-cleanup branch August 29, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants