Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for rules-based format #13

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add spec for rules-based format #13

merged 1 commit into from
Mar 9, 2018

Conversation

vasi-stripe
Copy link
Contributor

@vasi-stripe vasi-stripe commented Mar 9, 2018

It's nice to have docs!

"type": "match_list",
"property": "user",
"values": ["alice"],
"on_match": "on",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on_match should be continue here and on_miss should be off?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@asoni-stripe asoni-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one small nit!

@vasi-stripe
Copy link
Contributor Author

LGTM

Self-approving for fixes to spacing and nit

@vasi-stripe vasi-stripe merged commit 0bac624 into master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants