Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ideas for where to potentially log errors #8195

Closed
wants to merge 2 commits into from

Conversation

amk-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │ +1 B │   8.5 MiB │   8.5 MiB │  0 B 
     arsc │   2.2 MiB │   2.2 MiB │  0 B │   2.2 MiB │   2.2 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  24.9 KiB │  24.9 KiB │  0 B 
      res │ 911.1 KiB │ 911.1 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │     3 MiB │     3 MiB │  0 B │     3 MiB │     3 MiB │  0 B 
    other │ 204.2 KiB │ 204.2 KiB │ +7 B │ 445.3 KiB │ 445.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.8 MiB │  12.8 MiB │ +8 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42439 │ 42439 │ 0 (+0 -0) 
   types │ 14415 │ 14415 │ 0 (+0 -0) 
 classes │ 12148 │ 12148 │ 0 (+0 -0) 
 methods │ 60256 │ 60256 │ 0 (+0 -0) 
  fields │ 39807 │ 39807 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6029 │ 6029 │  0
APK
   compressed    │  uncompressed  │                                           
──────────┬──────┼─────────┬──────┤                                           
 size     │ diff │ size    │ diff │ path                                      
──────────┼──────┼─────────┼──────┼───────────────────────────────────────────
 62.1 KiB │ +7 B │ 140 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +1 B │   120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  3.9 MiB │ +1 B │ 8.5 MiB │  0 B │ ∆ classes.dex                             
  1.2 KiB │ -1 B │ 1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼─────────┼──────┼───────────────────────────────────────────
  3.9 MiB │ +8 B │ 8.6 MiB │  0 B │ (total)

@amk-stripe amk-stripe closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant