Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional plugin manifests #1067

Merged
merged 13 commits into from
May 3, 2023

Conversation

vcheung-stripe
Copy link
Collaborator

Reviewers

r? @
cc @stripe/developer-products

Summary

Add support for merging multiple plugin manifests into one plugins.toml, so we can conditionally enable plugin visibility for specific users. For example, to enable the foo plugin, we send to the client:

GET /v1/stripecli/get-plugin-url
{
  "base_url": "https://stripe.jfrog.io/artifactory/stripe-cli-plugins-local",
  "additional_manifests": [
    "plugins-foo.toml"
  ]
}

where plugins-foo.toml contains the manifest for foo, and the client handles merging the data into plugins.toml locally.

@vcheung-stripe vcheung-stripe marked this pull request as ready for review May 2, 2023 19:07
@vcheung-stripe vcheung-stripe requested a review from a team as a code owner May 2, 2023 19:07
@vcheung-stripe vcheung-stripe merged commit b1cfe3a into master May 3, 2023
@vcheung-stripe vcheung-stripe deleted the vcheung/additional-plugin-manifests branch May 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants