Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name and address to payment method billing details for checkout.s… #1087

Merged

Conversation

abirck-stripe
Copy link
Contributor

@abirck-stripe abirck-stripe commented Jun 16, 2023

…ession.completed webhook

Reviewers

r? @stripe/developer-products
cc @stripe/developer-products

Summary

Adds a billing name and address to the card payment method created as part of generating a checkout.session.completed webhook. This more realistically models actual payments because Checkout enforces card payments contain these attributes.

@abirck-stripe abirck-stripe requested a review from a team as a code owner June 16, 2023 17:11
@abirck-stripe abirck-stripe force-pushed the abirck/update-checkout-session-completed-webhook branch from d1a6f25 to 0fdb249 Compare June 16, 2023 17:28
Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@abirck-stripe abirck-stripe merged commit a4f13c9 into master Jun 16, 2023
@abirck-stripe abirck-stripe deleted the abirck/update-checkout-session-completed-webhook branch June 16, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants