Delegate plugin --help flag to the plugin #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
There is a bug where if you run a plugin command with --help or -h, you get the wrong output. This is because cobra parses the --help flag in the mainline CLI, bypassing the plugin process completely.
Expected:
Actual:
We fix this bug by overriding the default
help
function in the mainline CLI's plugin command: we call into the plugin process, passing along the --help flag so that the plugin process'shelp
function gets invoked.