Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable livemode key management #982

Merged
merged 10 commits into from
Oct 13, 2022
Merged

Re-enable livemode key management #982

merged 10 commits into from
Oct 13, 2022

Conversation

etsai-stripe
Copy link
Contributor

@etsai-stripe etsai-stripe commented Oct 7, 2022

Reviewers

r? @vcheung-stripe
cc @stripe/developer-products

Summary

  • restore storing livmode api keys by OS default credential management app
  • store livemode api keys by add-generic-password for macOS arm64, due to CGO incompatibility with keying library

@etsai-stripe etsai-stripe requested a review from a team as a code owner October 7, 2022 04:54
Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@etsai-stripe etsai-stripe merged commit e0b09ae into master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants