Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type information here and there #1612

Merged
merged 16 commits into from
Nov 11, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Nov 8, 2022

To simplify development and refactoring. Typechecks in strict mode. I've added @ts-ignore that require runtime changes to fix.

Types are a bit messy because the code wasn't always internally consistent but it's a start.

No runtime changes. No public type changes.

Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these!!

@pakrym-stripe
Copy link
Contributor Author

I'll merge after major.

@pakrym-stripe
Copy link
Contributor Author

@anniel-stripe this needs a re-review.

@pakrym-stripe
Copy link
Contributor Author

I won't wait for major. I'll merge master into sdk-release/next-major after merging this.

@pakrym-stripe pakrym-stripe merged commit 539e72c into master Nov 11, 2022
@remi-stripe remi-stripe deleted the pakrym/Add_type_information_here_and_there branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants