Handle Buffer.from TypeError on node versions prior to 4.5.x #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| return Buffer.from(thing); | ||
| } catch (e) { | ||
| if (e instanceof TypeError) { |
There was a problem hiding this comment.
Thanks for trying to minimize the scope of errors that we'll try to catch.
|
Thanks @cxam! This works for me. |
|
Released as 4.23.2. |
|
That's great @brahn-stripe, thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are currently failing on node v4 and versions prior to v4.5.x due to a mismatch in the Buffer.from API. This was fixed in nodejs/node#7562 and backported to v4.5.x. PR fixes the current use of the function by handling the TypeError being thrown.
Alternative solutions: