Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$stripe->rawRequest #1486

Merged
merged 22 commits into from
May 19, 2023
Merged

$stripe->rawRequest #1486

merged 22 commits into from
May 19, 2023

Conversation

richardm-stripe
Copy link
Contributor

No description provided.

@richardm-stripe richardm-stripe marked this pull request as draft April 27, 2023 22:43
@anniel-stripe anniel-stripe changed the base branch from master to beta May 16, 2023 17:23
@anniel-stripe anniel-stripe marked this pull request as ready for review May 18, 2023 18:19
lib/Preview.php Outdated Show resolved Hide resolved
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

@anniel-stripe anniel-stripe merged commit 2967c16 into beta May 19, 2023
@anniel-stripe anniel-stripe deleted the richardm-send-request branch May 19, 2023 16:08
prathmesh-stripe pushed a commit that referenced this pull request Aug 9, 2024
* Refactor CurlClient

* Public interface

* Test

* Better tests

* Better test

* Nicer types

* Add README.md entry

* encoding -> api_mode, support preview syntax

* Fix additional headers

* Generate preview version and formatting

* default to preview version if api mode is preview

* stripe_context

* Use setMethods, extract preview tests into separate file

* actually add preview tests

* fix tests

* fix tests

* remove old error handling

* feedback round 1

* assertEquals

* lint

* don't include stripe_version in preview default opts

* LINT

---------

Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe pushed a commit that referenced this pull request Aug 12, 2024
* Refactor CurlClient

* Public interface

* Test

* Better tests

* Better test

* Nicer types

* Add README.md entry

* encoding -> api_mode, support preview syntax

* Fix additional headers

* Generate preview version and formatting

* default to preview version if api mode is preview

* stripe_context

* Use setMethods, extract preview tests into separate file

* actually add preview tests

* fix tests

* fix tests

* remove old error handling

* feedback round 1

* assertEquals

* lint

* don't include stripe_version in preview default opts

* LINT

---------

Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe pushed a commit that referenced this pull request Aug 12, 2024
* Refactor CurlClient

* Public interface

* Test

* Better tests

* Better test

* Nicer types

* Add README.md entry

* encoding -> api_mode, support preview syntax

* Fix additional headers

* Generate preview version and formatting

* default to preview version if api mode is preview

* stripe_context

* Use setMethods, extract preview tests into separate file

* actually add preview tests

* fix tests

* fix tests

* remove old error handling

* feedback round 1

* assertEquals

* lint

* don't include stripe_version in preview default opts

* LINT

---------

Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe pushed a commit that referenced this pull request Aug 12, 2024
* Refactor CurlClient

* Public interface

* Test

* Better tests

* Better test

* Nicer types

* Add README.md entry

* encoding -> api_mode, support preview syntax

* Fix additional headers

* Generate preview version and formatting

* default to preview version if api mode is preview

* stripe_context

* Use setMethods, extract preview tests into separate file

* actually add preview tests

* fix tests

* fix tests

* remove old error handling

* feedback round 1

* assertEquals

* lint

* don't include stripe_version in preview default opts

* LINT

---------

Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe pushed a commit that referenced this pull request Aug 12, 2024
* Refactor CurlClient

* Public interface

* Test

* Better tests

* Better test

* Nicer types

* Add README.md entry

* encoding -> api_mode, support preview syntax

* Fix additional headers

* Generate preview version and formatting

* default to preview version if api mode is preview

* stripe_context

* Use setMethods, extract preview tests into separate file

* actually add preview tests

* fix tests

* fix tests

* remove old error handling

* feedback round 1

* assertEquals

* lint

* don't include stripe_version in preview default opts

* LINT

---------

Co-authored-by: Annie Li <anniel@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants