-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$stripe->rawRequest #1486
Merged
Merged
$stripe->rawRequest #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
force-pushed
the
richardm-send-request
branch
from
May 16, 2023 17:23
0d62cf9
to
c2359d7
Compare
pakrym-stripe
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits
prathmesh-stripe
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Refactor CurlClient * Public interface * Test * Better tests * Better test * Nicer types * Add README.md entry * encoding -> api_mode, support preview syntax * Fix additional headers * Generate preview version and formatting * default to preview version if api mode is preview * stripe_context * Use setMethods, extract preview tests into separate file * actually add preview tests * fix tests * fix tests * remove old error handling * feedback round 1 * assertEquals * lint * don't include stripe_version in preview default opts * LINT --------- Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Refactor CurlClient * Public interface * Test * Better tests * Better test * Nicer types * Add README.md entry * encoding -> api_mode, support preview syntax * Fix additional headers * Generate preview version and formatting * default to preview version if api mode is preview * stripe_context * Use setMethods, extract preview tests into separate file * actually add preview tests * fix tests * fix tests * remove old error handling * feedback round 1 * assertEquals * lint * don't include stripe_version in preview default opts * LINT --------- Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Refactor CurlClient * Public interface * Test * Better tests * Better test * Nicer types * Add README.md entry * encoding -> api_mode, support preview syntax * Fix additional headers * Generate preview version and formatting * default to preview version if api mode is preview * stripe_context * Use setMethods, extract preview tests into separate file * actually add preview tests * fix tests * fix tests * remove old error handling * feedback round 1 * assertEquals * lint * don't include stripe_version in preview default opts * LINT --------- Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Refactor CurlClient * Public interface * Test * Better tests * Better test * Nicer types * Add README.md entry * encoding -> api_mode, support preview syntax * Fix additional headers * Generate preview version and formatting * default to preview version if api mode is preview * stripe_context * Use setMethods, extract preview tests into separate file * actually add preview tests * fix tests * fix tests * remove old error handling * feedback round 1 * assertEquals * lint * don't include stripe_version in preview default opts * LINT --------- Co-authored-by: Annie Li <anniel@stripe.com>
prathmesh-stripe
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Refactor CurlClient * Public interface * Test * Better tests * Better test * Nicer types * Add README.md entry * encoding -> api_mode, support preview syntax * Fix additional headers * Generate preview version and formatting * default to preview version if api mode is preview * stripe_context * Use setMethods, extract preview tests into separate file * actually add preview tests * fix tests * fix tests * remove old error handling * feedback round 1 * assertEquals * lint * don't include stripe_version in preview default opts * LINT --------- Co-authored-by: Annie Li <anniel@stripe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.