Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #418

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Add more tests #418

merged 1 commit into from
Jan 11, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Adds a bunch of tests for previously untested codepaths.

Most of the remaining untested parts are overly defensive programming that we could arguably get rid of (e.g. handling the absence of an id attribute in non-singleton resources).

There are also some untested parts in CurlClient, mostly error conditions (connection failures, certificate verification failures, etc.). Those are not so easy to test unfortunately.

@brandur-stripe
Copy link
Contributor

Hard to argue with this PR!

LGTM.

@ob-stripe ob-stripe merged commit 0b5d382 into integration-v6 Jan 11, 2018
@ob-stripe ob-stripe deleted the ob-more-tests branch January 11, 2018 22:48
@ob-stripe ob-stripe mentioned this pull request Jan 11, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants