Ignore null values in params #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Sep 25, 2018
| public static function objectsToIds($h) | ||
| { | ||
| if ($h instanceof \Stripe\ApiResource) { | ||
| return $h->id; |
There was a problem hiding this comment.
I wonder if there will be some cases where some resources will not have an id and break this logic and we will regret this.
There was a problem hiding this comment.
Yeah, I considered that. This would only happen if a user passed a resource without an ID inside a parameter hash though. We could check if the resource has an id property and output an error message if not, but I don't think it's worth the hassle.
(stripe-ruby has the same issue fwiw)
tests/Stripe/Util/UtilTest.php
Outdated
| 'customer' => Util\Util::convertToStripeObject([ | ||
| 'id' => 'cus_123', | ||
| 'object' => 'customer', | ||
| ], null), |
There was a problem hiding this comment.
indentation on this kind of threw me off
ob-stripe
force-pushed
the
ob-fix-525
branch
from
cf172a6
to
275ce65
Compare
|
Released as 6.19.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries @EatonZ
This fixes a regression I caused in #517 that caused
nullvalues in parameters to be encoded as empty strings and sent in requests.stripe-ruby handles this via the
objects_to_idshelper method, whose main purpose is to replace instances of Stripe resources with their IDs, but that also clears null values. Since the parameter encoding logic in stripe-php is already very similar to stripe-ruby's, I simply ported the method.Fixes #525.