Add support for TaxId resource and APIs #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
2 times, most recently
from
498788c
to
dd08e97
Compare
remi-stripe
changed the title
|
This is now ready to be reviewed. |
remi-stripe
commented
Apr 19, 2019
| * | ||
| * @return ApiResource | ||
| */ | ||
| public static function createTaxId($id, $params = null, $opts = null) |
There was a problem hiding this comment.
Flagging that tax_ids the collection is returned on the Customer object, like sources and subscriptions. Not sure anymore if that changes things
ob-stripe
suggested changes
Apr 19, 2019
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
dd08e97
to
89e0f5c
Compare
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
89e0f5c
to
7385e22
Compare
|
@ob-stripe PTAL |
ob-stripe
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries @nicku-stripe