Fixed phpdoc/constants for Customer, Invoice and TaxID #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Apr 24, 2019
There was a problem hiding this comment.
Thanks for the fix as usual @nickdnk! Would you be up for also fixing Invoice since it got a lot of new properties too?
|
cracks knuckles - watch this! |
|
Made a few adjustments. Namely to Should be good now. Edit: I also adjusted TaxID phpdocs and added missing constants on |
nickdnk
changed the title
Fixed TaxID php docs and added constants Fixed phpdocs for Invoice
remi-stripe
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to customer tax ID logic, there have been a few changes to the customer object.
Updates reflected in this PR.
I removed the deprecated properties. Not sure if you want them to remain. I figure it's good practice to remove them as this draws attention to them having been deprecated without breaking anything.