Fix idempotency key check when using automatic retries #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Apr 26, 2019
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
minor but isn't this quite slow/overhead? Should we maybe store "this information" (the fact that we set an idempotency key) elsewhere?
There was a problem hiding this comment.
Not really possible without modifying ClientInterface unfortunately.
brandur-stripe
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
When using automatic retries,
CurlClientoverwrites the existing idempotency key because$headersis a list of strings and not a map of key/values. This PR fixes it by adding ahasHeaderhelper method to check if a list of headers already has a specific header.Fixes #637.
No tests because
CurlClientis ~impossible to test :(