Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make \Stripe\Collection implement \Countable #879

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @richardm-stripe
cc @stripe/api-libraries

Make \Stripe\Collection implement \Countable, so that calling count($page) will return the number of objects in the page rather than the number of keys on the page object.

Fixes #807.

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me!

@ob-stripe ob-stripe merged commit cb44b0b into master Feb 14, 2020
@ob-stripe ob-stripe deleted the ob-list-countable branch February 14, 2020 22:28
@ob-stripe
Copy link
Contributor Author

Released as 7.25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong invoices count (always 4)
4 participants