Unit test resource classes instead of hitting the API #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks sane to me. Would be nice if we had code coverage statistics to verify all error cases, parser paths, etc. are still being tested, but c'est la vie. |
kyleconroy
added a commit
that referenced
this pull request
Jul 18, 2014
Unit test resource classes instead of hitting the API
|
I think the improved test speeds and reliability are a big win here. I did like the property of the old tests that I was really sure it interacted properly with the actual API. |
|
I wonder if it is feasible to test against the actual API before doing a release but use the new tests at other times. |
|
@metcalf Note that we still make live API requests in the test suite, so we can be quite confidant that the library interacts correctly with the API. |
speedplane
pushed a commit
to speedplane/stripe-python
that referenced
this pull request
Jul 9, 2015
Unit test resource classes instead of hitting the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, tests now take 10 seconds instead of 70.
r? @metcalf @wangjohn