Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog api key is leaking into logs in default config #534

Closed
SleepyBrett opened this issue Aug 24, 2018 · 1 comment
Closed

Datadog api key is leaking into logs in default config #534

SleepyBrett opened this issue Aug 24, 2018 · 1 comment

Comments

@SleepyBrett
Copy link

Starting up the software with no configuration overrides etc. places logging into debug mode which results in log messages like this:

time="2018-08-24T20:13:02Z" level=debug msg="POSTed successfully" action=flush endpoint="https://app.datadoghq.com/api/v1/series?api_key=<MY ACTUAL API KEY>" request_headers="map[Content-Encoding:[deflate] Traceid:[7918023244848592696] Parentid:[3942115212271789064] Spanid:[1544772588644824963] Resource:[flush] Content-Type:[application/json]]" request_length=29313 response="{\"status\": \"ok\"}" response_headers="map[Content-Length:[16] Dd-Pool:[propjoe] X-Content-Type-Options:[nosniff] Strict-Transport-Security:[max-age=15724800;] Date:[Fri, 24 Aug 2018 20:13:02 GMT] Content-Type:[text/json]]" status="202 Accepted"

While I think there is some value in outputting the datadog apikey in a debug message I think that both for security and sanity that logging should probably not be set to debug level by default. Or that examples like this one (https://varnull.adityamukerjee.net/2018/04/05/observing-kubernetes-services-with-veneur/) should probably show how to override the log level.

@ChimeraCoder
Copy link
Contributor

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants