Correctly store the commonTags in for later use in Lightstep span sink #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of commonTags were provided to the Lightstep span sink, but they were not permanently recorded into the struct; as such, no common tags were ever applied to outgoing spans.
sdboyer-stripe
force-pushed
the
ls-comtags
branch
from
d32dd4f
to
fba11b4
Compare
Gerald Rule: Copy Observability on Veneur and Unilog pull requestscc @stripe/observability |
sdboyer-stripe
changed the title
|
Eep! Can you audit the Kafka sink as well? I had a note it might have this problem… |
|
Hmm, right now, the kafka sink doesn't appear to support even the concept of common tags - they're missing entirely. Do they need to be added? |
|
Closing this now, it's not actually how we want commonTags to behave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A set of commonTags were provided to the Lightstep span sink, but they
were not permanently recorded into the struct; as such, no common tags
were ever applied to outgoing spans.
Motivation
Seems like a pretty clear bug?
Test plan
Simple addition to a relevant test.
Rollout/monitoring/revert plan