breaking: rename content type OEMBED to EMBED #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobaaaaa
added
💥 breaking change
bobaaaaa
requested review from
harryherbig,
moritzzimmer and
thisismana
as code owners
🔥 Breaking Changes |
moritzzimmer
approved these changes
Sep 6, 2021
This should be wire compatible for gRPC users (would be breaking for users of a REST API), so should be able to safely release this. |
🔥 Breaking Changes |
thisismana
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more accurate name for this main type. Because we use this type to transport
edge_side_includeoroembedelement in it.Question:
This change is not breaking our stored proto article data and an outdated service. But it is a breaking change for a code base which uses tapir. Would we label this as a breaking change?