feat(): articles need fields like in the section pages for sdi zones #529
Conversation
bastianpahlke
requested review from
moritzzimmer,
harryherbig,
thisismana,
bobaaaaa and
saefty
as code owners
bastianpahlke
changed the title
bastianpahlke
changed the title
bastianpahlke
force-pushed
the
BUZZ-3868
branch
from
98269a5
to
0d19c6b
Compare
| // meta information to render an article page such as commercial settings. | ||
| stroeer.page.section.v1.SectionPage.Section section = 5; |
There was a problem hiding this comment.
This looks wrong to me. The equivalent of SectionPage.Section.fields is ArticlePage.Article.fields
There was a problem hiding this comment.
that is true, and I also thought about just adding the fields, but since there are efforts to make ArticlePage and SectionPage models more similar, I preferred to use the whole Section field.
@bobaaaaa
There was a problem hiding this comment.
I know the issue. We need to deal with that in our FE too. I created an interface around ArticlePage and SectionPage for that reason.
Still: this change is wrong to me because of duplicate data. E.g. ArticlePage.article.section_tree & ArticlePage.section.section_tree
There was a problem hiding this comment.
To quote Imogen Heap: "Where do we go from here":
So just the fields than or is something wrong with that too? Since we want to keep sections and articles more alike.
Done in collaboration with @harryherbig
Sections already have an option to expose various fields, but articles do not so far. This pull request will change that.
@stroeer/buzz-end Please check this as it is my first approach on this repo