-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Flow to TypeScript #5
Conversation
bcf2091
to
eb9791f
Compare
Great, super excited to start working on this out in the open! Before we move this PR out of WIP, i have the following requests:
|
eb9791f
to
c6e3c11
Compare
c6e3c11
to
a04029e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have to get used to this double-submission of review comments...
82b7f2b
to
1c54a34
Compare
fde564b
to
a8cb07d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still figuring out what useful comment to write here when submitting a review :D
a8cb07d
to
f898eea
Compare
f898eea
to
f172893
Compare
2d280e3
to
278e7ff
Compare
Goal of this initial PR is to have a drop-in replacement for our existing
@brickblock/strong-config
. This means primarily that all flow-types are converted to Typescript typings. Additionally, typescript-specific project setup, CI setup, unit tests, dynamic type generation for Config object.Donezo:
Not in the scope of this MR:
.gitlab-ci.yml
These and more should be extracted into separate GitHub issues and addressed in future, hopepfully smaller, PRs