adding handler for createReviews err, fixing misspelling, removing un… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I would like @superkhau to take a quick look before merging just to confirm. |
|
LGTM |
crandmck
pushed a commit
that referenced
this pull request
Aug 26, 2015
adding handler for createReviews err, fixing misspelling, removing un…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the ignored err returned from createReviews.
If a user makes a typographic error when creating the model attributes, the data connector will return an error because the attribute names in create-sample-model.js do not match the model's attribute names. This error will be ignored because it is not handled by the callback.
Also fixing a misspelling and removing unnecessary commas.