Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): fix typo in README #2304

Closed
wants to merge 1 commit into from

Conversation

blackrabbit99
Copy link

Small fix in documentation

@raymondfeng
Copy link
Contributor

@blackrabbit99 Thank you for the patch.

  • Please sign CLA
  • Amend the commit message to be something like fix(rest): fix typo in README.

@blackrabbit99 blackrabbit99 changed the title Update incorrect variable name in example fix(rest): fix typo in README Jan 30, 2019
@raymondfeng
Copy link
Contributor

@blackrabbit99 You only changed the title of the PR, which is different from the commit message. See https://help.github.com/articles/changing-a-commit-message/.

@raymondfeng
Copy link
Contributor

@blackrabbit99 You need to sign CLA by clicking https://cla.strongloop.com/agreements/strongloop/loopback-next.

@bajtos
Copy link
Member

bajtos commented Feb 8, 2019

@blackrabbit99 ping 👋 What's the status of this pull request? Are you still keen to get it finished? We can fix the commit message for you, but there is no way around the requirement that we need you to sign our CLA first. https://cla.strongloop.com/agreements/strongloop/loopback-next

@bajtos
Copy link
Member

bajtos commented Mar 1, 2019

Closing as abandoned 😢

@bajtos bajtos closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants