Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused juggler import #2319

Merged
merged 1 commit into from
Jan 31, 2019
Merged

fix: remove unused juggler import #2319

merged 1 commit into from
Jan 31, 2019

Conversation

nabdelgadir
Copy link
Contributor

VSCode complains about the unused juggler import in a repository generated from the CLI. juggler was used before as juggler.DataSource which was changed into dataSourceClassName (see commit where it was changed).

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@nabdelgadir nabdelgadir self-assigned this Jan 31, 2019
jannyHou
jannyHou approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI green :shipit:

b-admike
b-admike approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@nabdelgadir nabdelgadir merged commit 0121c10 into master Jan 31, 2019
@nabdelgadir nabdelgadir deleted the remove-juggler-import branch January 31, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabdelgadir @jannyHou @b-admike