feat(context): explicitly support async BindingEventListener #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achrinza
requested review from
emonddr,
jannyHou and
raymondfeng
as code owners
achrinza
force-pushed
the
feat/bindingeventlistener-promise
branch
from
6fe64af
to
1bbfe9b
Compare
achrinza
added
the
IoC/Context
Prevent conflict with '@typescript-eslint/no-misused-promises' ESLint rule. Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
feat/bindingeventlistener-promise
branch
from
1bbfe9b
to
6394af6
Compare
|
ValueOrPromise does not make the listener to be async. |
|
You're right, this was the wrong approach to solve issue. Will proceed to close it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent conflict with '@typescript-eslint/no-misused-promises' ESLint rule.
Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈