Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish updating this repository #94

Open
shimks opened this issue Apr 9, 2018 · 3 comments
Open

Finish updating this repository #94

shimks opened this issue Apr 9, 2018 · 3 comments

Comments

@shimks
Copy link
Contributor

shimks commented Apr 9, 2018

There is still some follow up work that needs to be done after #78 (taken from my comment here)

  • follow the instuctions on the README and update either the README or the code to make the repository's features apparent and complete
    • currently, following the steps on README will result in errors
  • leverage lerna to resolve dependencies between services
  • use automatic openapi-v3 schema decorators instead of explicitly defining schemas
    • unless that's the point of this repository. In that case, this repository should be archived until we fully commit to supporting top-down approach.
  • use 'models' and their decorators to define custom types
  • complete switching over repositories to extend from DefaultCrudRepository
  • follow file naming convention advocated over here
  • look into potentially switching from loopback-swagger-connector since LoopBack 4 no longer supports swagger-v2.

There may be a lot being covered in this issue, so it might be appropriate to turn this into an epic.

Description/Steps to reproduce

Link to reproduction sandbox

Expected result

Additional information

@dhmlau
Copy link
Member

dhmlau commented Apr 10, 2018

related to: loopbackio/loopback-next#669

@thinusn
Copy link
Contributor

thinusn commented May 2, 2018

I think to make this example more useful we should definitely consider adding lerna

@dhmlau
Copy link
Member

dhmlau commented May 5, 2018

@thinusn , would you like to submit a PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants